[ https://issues.apache.org/jira/browse/GEODE-3213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16093853#comment-16093853 ]
ASF GitHub Bot commented on GEODE-3213: --------------------------------------- GitHub user pivotal-amurmann opened a pull request: https://github.com/apache/geode/pull/646 GEODE-3213: Refactor ProtoBuf handler flow Signed-off-by: Alexander Murmann <amurm...@pivotal.io> Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? GEODE-3213 - [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [x] Is your initial contribution a single, squashed commit? - [x] Does `gradlew build` run cleanly? - [x] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? NA ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/pivotal-amurmann/geode GEODE-3213 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/646.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #646 ---- commit bc9de5361e288199fbd0f22264ebf2a6ba6190e2 Author: Galen O'Sullivan <gosulli...@pivotal.io> Date: 2017-07-17T18:18:57Z GEODE-3213: Refactor ProtoBuf handler flow Signed-off-by: Alexander Murmann <amurm...@pivotal.io> ---- > Refactor Protobuf Serialization Implemenation > --------------------------------------------- > > Key: GEODE-3213 > URL: https://issues.apache.org/jira/browse/GEODE-3213 > Project: Geode > Issue Type: Improvement > Components: client/server, serialization > Reporter: Udo Kohlmeyer > > In the Protobuf serialization implementation, there are some refactorings we > want to make: > * OperationHandlers take OperationRequest and OperationResponse message, not > the parent Request/Response Object > * A generic flow needs to be implemented that all OperationHandlers follow. > No bespoke flows for any OperationHandlers... way too much maintenance > * Use Functional semantics to configure the functionality to extract > OperationRequest from Request (per OperationHandler) > * Use Functional semantics to configure the functionality to populate > OperationResponse in the relevant Response > * Have generic Error Handling framework to populate "known" errors and error > codes -- This message was sent by Atlassian JIRA (v6.4.14#64029)