[
https://issues.apache.org/jira/browse/GEODE-3213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094914#comment-16094914
]
ASF GitHub Bot commented on GEODE-3213:
---------------------------------------
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128386591
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandlerJUnitTest.java
---
@@ -64,11 +72,10 @@ public void setUp() throws Exception {
public void test_puttingTheEncodedEntryIntoRegion() throws
UnsupportedEncodingTypeException,
CodecNotRegisteredForTypeException,
CodecAlreadyRegisteredForTypeException {
PutRequestOperationHandler operationHandler = new
PutRequestOperationHandler();
- ClientProtocol.Response response =
+ Result<RegionAPI.PutResponse> result =
operationHandler.process(serializationServiceStub,
generateTestRequest(), cacheStub);
-
Assert.assertEquals(ClientProtocol.Response.ResponseAPICase.PUTRESPONSE,
- response.getResponseAPICase());
+ Assert.assertNotNull(result);
--- End diff --
We should assert that we got back a Success Object rather than just result
!= null
> Refactor Protobuf Serialization Implemenation
> ---------------------------------------------
>
> Key: GEODE-3213
> URL: https://issues.apache.org/jira/browse/GEODE-3213
> Project: Geode
> Issue Type: Improvement
> Components: client/server, serialization
> Reporter: Udo Kohlmeyer
>
> In the Protobuf serialization implementation, there are some refactorings we
> want to make:
> * OperationHandlers take OperationRequest and OperationResponse message, not
> the parent Request/Response Object
> * A generic flow needs to be implemented that all OperationHandlers follow.
> No bespoke flows for any OperationHandlers... way too much maintenance
> * Use Functional semantics to configure the functionality to extract
> OperationRequest from Request (per OperationHandler)
> * Use Functional semantics to configure the functionality to populate
> OperationResponse in the relevant Response
> * Have generic Error Handling framework to populate "known" errors and error
> codes
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
