[
https://issues.apache.org/jira/browse/GEODE-3412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123667#comment-16123667
]
ASF GitHub Bot commented on GEODE-3412:
---------------------------------------
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/707#discussion_r132737182
--- Diff:
geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java
---
@@ -1378,6 +1379,18 @@
*/
String NAME = "name";
/**
+ * The authentication mode for the protobuf client-server protocol.
+ *
+ * </p>
+ * <U>Description</U>: Specifies the authentication mode used by the
geode-protobuf module.
+ * </p>
+ * <U>Default</U>: "NOOP"
+ * </p>
+ * <U>Allowed values</U>: "NOOP" "SIMPLE"
+ */
+ @Experimental
+ String PROTOBUF_PROTOCOL_AUTHENTICATION_MODE =
"protobuf-protocol-authentication-mode";
--- End diff --
This property is misleading. It is NOT a protobuf specific authentication
mode. It is merely an authentication mechanism that uses protobuf underneath
the covers.
1) A different property name is to be used
2) With this property, the feature toggle should also maybe be removed??!!?
One cannot live without the other
> Implement a basic authentication mechanism for the new protocol
> ---------------------------------------------------------------
>
> Key: GEODE-3412
> URL: https://issues.apache.org/jira/browse/GEODE-3412
> Project: Geode
> Issue Type: New Feature
> Components: client/server
> Reporter: Brian Rowe
>
> Implement a simple username/password authentication for the new protocol.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
