[ https://issues.apache.org/jira/browse/GEODE-3412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123665#comment-16123665 ]
ASF GitHub Bot commented on GEODE-3412: --------------------------------------- Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/707#discussion_r132738771 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java --- @@ -63,6 +65,31 @@ private static ClientProtocolMessageHandler findClientProtocolMessageHandler() { } } + private static Class<? extends StreamAuthenticator> findStreamAuthenticator( + String implementationID) { + if (authenticatorClass != null) { + return authenticatorClass; + } + + synchronized (streamAuthenticatorLoadLock) { --- End diff -- why do we prefer this approach over a synchronized method? > Implement a basic authentication mechanism for the new protocol > --------------------------------------------------------------- > > Key: GEODE-3412 > URL: https://issues.apache.org/jira/browse/GEODE-3412 > Project: Geode > Issue Type: New Feature > Components: client/server > Reporter: Brian Rowe > > Implement a simple username/password authentication for the new protocol. -- This message was sent by Atlassian JIRA (v6.4.14#64029)