[
https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16126046#comment-16126046
]
ASF GitHub Bot commented on GEODE-3434:
---------------------------------------
Github user DivineEnder commented on a diff in the pull request:
https://github.com/apache/geode/pull/712#discussion_r133012057
--- Diff:
geode-assembly/src/test/java/org/apache/geode/session/tests/TomcatInstall.java
---
@@ -150,6 +166,66 @@ public TomcatInstall(TomcatVersion version,
ConnectionType connType, String inst
}
/**
+ * Copies jars specified by {@link #tomcatRequiredJars} from the {@link
#getModulePath()} and the
+ * specified other directory passed to the function
+ *
+ * @throws IOException if the {@link #getModulePath()}, installation lib
directory, or extra
+ * directory passed in contain no files.
+ */
+ private void copyTomcatGeodeReqFiles(String moduleJarDir, String
extraJarsPath)
--- End diff --
Copy stuff in function into other function
> Allow the modules to be interoperable with current and older versions of
> tomcat 7
> ----------------------------------------------------------------------------------
>
> Key: GEODE-3434
> URL: https://issues.apache.org/jira/browse/GEODE-3434
> Project: Geode
> Issue Type: Bug
> Components: http session
> Reporter: Jason Huynh
> Assignee: Jason Huynh
>
> There was a change to the attribute field in tomcat (and we made the
> necessary changes in geode session modules), but that does not allow our
> session modules to work with older versions of tomcat 7. We can probably
> modify the classes to allow use with of the session module jars across
> different versions of tomcat 7.
> We should probably add tests that run against older versions of geode to
> allow backwards compatibility between a geode server and a session module jar
> from a previous release.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
