[
https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131287#comment-16131287
]
ASF GitHub Bot commented on GEODE-3434:
---------------------------------------
Github user upthewaterspout commented on a diff in the pull request:
https://github.com/apache/geode/pull/712#discussion_r133827499
--- Diff:
extensions/geode-modules/src/main/java/org/apache/geode/modules/session/catalina/DeltaSession.java
---
@@ -553,8 +555,30 @@ public void fromData(DataInput in) throws IOException,
ClassNotFoundException {
}
}
- protected Map readInAttributes(final DataInput in) throws IOException,
ClassNotFoundException {
- return DataSerializer.readObject(in);
+ private void readInAttributes(DataInput in) throws IOException,
ClassNotFoundException {
+ Map map = DataSerializer.readObject(in);
+ ConcurrentMap newMap = new ConcurrentHashMap();
+ newMap.putAll(map);
+ try {
+ Field field = getAttributesFieldObject();
+ field.setAccessible(true);
+ field.set(this, newMap);
+ } catch (NoSuchFieldException e) {
+ logError(e);
--- End diff --
I think it would be better to throw an exception than log an error here, so
it's obvious if something is broken here.
> Allow the modules to be interoperable with current and older versions of
> tomcat 7
> ----------------------------------------------------------------------------------
>
> Key: GEODE-3434
> URL: https://issues.apache.org/jira/browse/GEODE-3434
> Project: Geode
> Issue Type: Bug
> Components: http session
> Reporter: Jason Huynh
> Assignee: Jason Huynh
>
> There was a change to the attribute field in tomcat (and we made the
> necessary changes in geode session modules), but that does not allow our
> session modules to work with older versions of tomcat 7. We can probably
> modify the classes to allow use with of the session module jars across
> different versions of tomcat 7.
> We should probably add tests that run against older versions of geode to
> allow backwards compatibility between a geode server and a session module jar
> from a previous release.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
