[ 
https://issues.apache.org/jira/browse/GEODE-3406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130868#comment-16130868
 ] 

ASF GitHub Bot commented on GEODE-3406:
---------------------------------------

Github user kohlmu-pivotal commented on a diff in the pull request:

    https://github.com/apache/geode/pull/716#discussion_r133775690
  
    --- Diff: 
geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java ---
    @@ -76,7 +76,9 @@
      */
     public interface InternalCache extends Cache, Extensible<Cache>, CacheTime 
{
     
    -  InternalDistributedMember getMyId();
    +  default InternalDistributedMember getMyId() {
    --- End diff --
    
    so the default implementation will result in a potential NPE?!?!? I think 
this should NOT have a default and each InternalCache should implement this.


> Enable new flow for protocol on locators
> ----------------------------------------
>
>                 Key: GEODE-3406
>                 URL: https://issues.apache.org/jira/browse/GEODE-3406
>             Project: Geode
>          Issue Type: Sub-task
>          Components: client/server
>            Reporter: Brian Baynes
>            Assignee: Alexander Murmann
>
> Enable magic byte and new flow for new protocol on locators.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to