[
https://issues.apache.org/jira/browse/GEODE-3406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130904#comment-16130904
]
ASF GitHub Bot commented on GEODE-3406:
---------------------------------------
Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/716#discussion_r133781367
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandlerJUnitTest.java
---
@@ -32,75 +30,48 @@
import org.junit.Test;
import org.junit.experimental.categories.Category;
-import java.io.IOException;
import java.util.ArrayList;
-import java.util.Properties;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;
import static org.mockito.ArgumentMatchers.any;
-import static org.mockito.ArgumentMatchers.anyBoolean;
-import static org.mockito.ArgumentMatchers.anyInt;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
@Category(UnitTest.class)
public class GetAvailableServersOperationHandlerJUnitTest extends
OperationHandlerJUnitTest {
- private TcpClient mockTCPClient;
+ public static final String HOSTNAME_1 = "hostname1";
--- End diff --
most likely these don't have to be 'public' AND 'static'. I believe
'private' and 'final' would be enough
> Enable new flow for protocol on locators
> ----------------------------------------
>
> Key: GEODE-3406
> URL: https://issues.apache.org/jira/browse/GEODE-3406
> Project: Geode
> Issue Type: Sub-task
> Components: client/server
> Reporter: Brian Baynes
> Assignee: Alexander Murmann
>
> Enable magic byte and new flow for new protocol on locators.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
