[ https://issues.apache.org/jira/browse/GEODE-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131404#comment-16131404 ]
ASF GitHub Bot commented on GEODE-3434: --------------------------------------- GitHub user jhuynh1 opened a pull request: https://github.com/apache/geode/pull/718 GEODE-3434: Allow old tomcat server sessions to be compatible with new tomcat session modules Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/geode feature/GEODE-3434 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/718.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #718 ---- commit 08c29c8df14b8cc315551297477636237e855b48 Author: Jason Huynh <huyn...@gmail.com> Date: 2017-08-14T16:02:11Z GEODE-3434: Allow the modules to be interoperable with current and older versions of tomcat 7 Modified DeltaSessions to use reflection to handle attributes fields incase an earlier tomcat 7 is used Modified DeltaSession7 and DeltaSession8 to extend from DeltaSession Added session backward compatibility tests Modified aseembly build to download old product installs commit dfce284c2634ea72e797ad4a9d8c956b8d86211c Author: Jason Huynh <huyn...@gmail.com> Date: 2017-08-14T19:07:08Z GEODE-3434: Modifications based on review comments commit be305896685e1b7d4d1f37724f673701277e5a76 Author: Jason Huynh <huyn...@gmail.com> Date: 2017-08-15T18:46:16Z Removed unused import commit d282ec4470a3993f7b401675bf7eb4161e1fb66e Author: Jason Huynh <huyn...@gmail.com> Date: 2017-08-17T22:04:42Z updated ---- > Allow the modules to be interoperable with current and older versions of > tomcat 7 > ---------------------------------------------------------------------------------- > > Key: GEODE-3434 > URL: https://issues.apache.org/jira/browse/GEODE-3434 > Project: Geode > Issue Type: Bug > Components: http session > Reporter: Jason Huynh > Assignee: Jason Huynh > > There was a change to the attribute field in tomcat (and we made the > necessary changes in geode session modules), but that does not allow our > session modules to work with older versions of tomcat 7. We can probably > modify the classes to allow use with of the session module jars across > different versions of tomcat 7. > We should probably add tests that run against older versions of geode to > allow backwards compatibility between a geode server and a session module jar > from a previous release. -- This message was sent by Atlassian JIRA (v6.4.14#64029)