[
https://issues.apache.org/jira/browse/GEODE-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16236745#comment-16236745
]
ASF GitHub Bot commented on GEODE-3007:
---------------------------------------
jaredjstewart opened a new pull request #1011: GEODE-3007: Simplify support for
custom GFSH commands
URL: https://github.com/apache/geode/pull/1011
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ x] Is your initial contribution a single, squashed commit?
- [x ] Does `gradlew build` run cleanly?
- [x ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Simplify support for custom GFSH commands
> -----------------------------------------
>
> Key: GEODE-3007
> URL: https://issues.apache.org/jira/browse/GEODE-3007
> Project: Geode
> Issue Type: Improvement
> Components: gfsh
> Reporter: Jared Stewart
> Assignee: Jared Stewart
> Priority: Major
>
> Geode currently supports three ways to load GFSH commands:
> 1. Scan the classpath for commands in
> "org.apache.geode.management.internal.cli.commands”
> 2. Scan the classpath for commands in a package specified by a user via the
> “user-command-packages” system property.
> 3. Scan the classpath for commands registered in files inside
> META-INF.services (e.g.
> "geode-core/src/test/resources/META-INF/services/org.springframework.shell.core.CommandMarker”)
>
> After the improvements made by GEODE-2989, there is no reason to require a
> user to specify the location of their custom commands via one of these
> mechanisms. Instead, we should simply scan the entire classpath for any
> classes implementing CommandMarker (regardless of whatever packages they live
> in).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
