[
https://issues.apache.org/jira/browse/GEODE-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238078#comment-16238078
]
ASF GitHub Bot commented on GEODE-3007:
---------------------------------------
jdeppe-pivotal commented on a change in pull request #1011: GEODE-3007:
Simplify support for custom GFSH commands
URL: https://github.com/apache/geode/pull/1011#discussion_r148852585
##########
File path:
geode-core/src/main/java/org/apache/geode/management/internal/cli/CommandManager.java
##########
@@ -14,293 +14,96 @@
*/
package org.apache.geode.management.internal.cli;
-import static
org.apache.geode.distributed.ConfigurationProperties.USER_COMMAND_PACKAGES;
-import java.lang.reflect.Method;
-import java.util.ArrayList;
-import java.util.HashSet;
-import java.util.Iterator;
-import java.util.List;
-import java.util.Properties;
-import java.util.ServiceConfigurationError;
-import java.util.ServiceLoader;
+import static java.util.stream.Collectors.toSet;
+
+import java.util.Objects;
import java.util.Set;
-import java.util.StringTokenizer;
+import java.util.function.Predicate;
+import com.google.common.collect.ImmutableSet;
Review comment:
It seems this is the only reason we're pulling in guava? I'd prefer not to
pull in a new dependency if we don't need to (especially when it is not being
used pervasively). It reduces the chance of future conflicts with user's
application code which also uses that dependency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Simplify support for custom GFSH commands
> -----------------------------------------
>
> Key: GEODE-3007
> URL: https://issues.apache.org/jira/browse/GEODE-3007
> Project: Geode
> Issue Type: Improvement
> Components: docs, gfsh
> Reporter: Jared Stewart
> Assignee: Jared Stewart
> Priority: Major
>
> Geode currently supports three ways to load GFSH commands:
> 1. Scan the classpath for commands in
> "org.apache.geode.management.internal.cli.commands”
> 2. Scan the classpath for commands in a package specified by a user via the
> “user-command-packages” system property.
> 3. Scan the classpath for commands registered in files inside
> META-INF.services (e.g.
> "geode-core/src/test/resources/META-INF/services/org.springframework.shell.core.CommandMarker”)
>
> After the improvements made by GEODE-2989, there is no reason to require a
> user to specify the location of their custom commands via one of these
> mechanisms. Instead, we should simply scan the entire classpath for any
> classes implementing CommandMarker (regardless of whatever packages they live
> in).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
