[
https://issues.apache.org/jira/browse/GEODE-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16253592#comment-16253592
]
ASF GitHub Bot commented on GEODE-3392:
---------------------------------------
dgkimura commented on a change in pull request #150: GEODE-3392: Converts
CacheStatistics to std::chrono.
URL: https://github.com/apache/geode-native/pull/150#discussion_r151154153
##########
File path: clicache/test/TimeUtilsTests.cpp
##########
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "begin_native.hpp"
+#include <chrono>
+#include "end_native.hpp"
+#include "TimeUtils.hpp"
+
+using namespace System;
+using namespace System::Text;
+using namespace System::Collections::Generic;
+using namespace Microsoft::VisualStudio::TestTools::UnitTesting;
+
+using namespace std::chrono;
+
+using namespace Apache::Geode::Client;
+
+namespace cliunittests
+{
+ [TestClass]
+ public ref class TimeUtilsTests
+ {
+ private:
+ TestContext^ testContextInstance;
+
+ public:
+ /// <summary>
+ ///Gets or sets the test context which provides
+ ///information about and functionality for the current test run.
+ ///</summary>
+ property
Microsoft::VisualStudio::TestTools::UnitTesting::TestContext^ TestContext
+ {
+
Microsoft::VisualStudio::TestTools::UnitTesting::TestContext^ get()
+ {
+ return testContextInstance;
+ }
+ System::Void
set(Microsoft::VisualStudio::TestTools::UnitTesting::TestContext^ value)
+ {
+ testContextInstance = value;
+ }
+ };
+
+ #pragma region Additional test attributes
+ //
+ //You can use the following additional attributes as you write
your tests:
+ //
+ //Use ClassInitialize to run code before running the first test
in the class
+ //[ClassInitialize()]
+ //static void MyClassInitialize(TestContext^ testContext) {};
+ //
+ //Use ClassCleanup to run code after all tests in a class have
run
+ //[ClassCleanup()]
+ //static void MyClassCleanup() {};
+ //
+ //Use TestInitialize to run code before running each test
+ //[TestInitialize()]
+ //void MyTestInitialize() {};
+ //
+ //Use TestCleanup to run code after each test has run
+ //[TestCleanup()]
+ //void MyTestCleanup() {};
+ //
+ #pragma endregion
+
+ [TestMethod]
Review comment:
Nit - mixing spaces/tabs in this file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Migrate CacheStatistics to use std::chrono
> ------------------------------------------
>
> Key: GEODE-3392
> URL: https://issues.apache.org/jira/browse/GEODE-3392
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Ernest Burghardt
>
> virtual std::chrono::time_point getLastModifiedTime() const;
> /**
> * For an entry, returns the last time it was accessed via
> * @see Region::get
> * @see getLastModifiedTime
> */
> virtual std::chrono::time_point getLastAccessedTime() const;
> private:
> virtual void setLastAccessedTime(std::chrono::time_point lat);
> virtual void setLastModifiedTime(std::chrono::time_point lmt);
> std::atomic<std::chrono::time_point> m_lastAccessTime;
> std::atomic<std::chrono::time_point> m_lastModifiedTime;
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
