[
https://issues.apache.org/jira/browse/GEODE-3392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16253617#comment-16253617
]
ASF GitHub Bot commented on GEODE-3392:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #150: GEODE-3392:
Converts CacheStatistics to std::chrono.
URL: https://github.com/apache/geode-native/pull/150#discussion_r151159257
##########
File path: cppcache/integration-test/CacheHelper.cpp
##########
@@ -494,26 +494,30 @@ std::shared_ptr<Pool> CacheHelper::createPool2(
}
void CacheHelper::logPoolAttributes(std::shared_ptr<Pool>& pool) {
+ using namespace apache::geode::util::chrono::duration;
LOG("logPoolAttributes() entered");
LOGINFO("CPPTEST: Pool attribtes for pool %s are as follows:",
pool->getName());
- LOGINFO("getFreeConnectionTimeout: %d", pool->getFreeConnectionTimeout());
+ LOGINFO("getFreeConnectionTimeout: %s",
+ to_string(pool->getFreeConnectionTimeout()).c_str());
LOGINFO("getLoadConditioningInterval: %d",
- pool->getLoadConditioningInterval());
+ to_string(pool->getLoadConditioningInterval()).c_str());
LOGINFO("getSocketBufferSize: %d", pool->getSocketBufferSize());
- LOGINFO("getReadTimeout: %d", pool->getReadTimeout());
+ LOGINFO("getReadTimeout: %d", to_string(pool->getReadTimeout()).c_str());
Review comment:
Yes great catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Migrate CacheStatistics to use std::chrono
> ------------------------------------------
>
> Key: GEODE-3392
> URL: https://issues.apache.org/jira/browse/GEODE-3392
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Ernest Burghardt
>
> virtual std::chrono::time_point getLastModifiedTime() const;
> /**
> * For an entry, returns the last time it was accessed via
> * @see Region::get
> * @see getLastModifiedTime
> */
> virtual std::chrono::time_point getLastAccessedTime() const;
> private:
> virtual void setLastAccessedTime(std::chrono::time_point lat);
> virtual void setLastModifiedTime(std::chrono::time_point lmt);
> std::atomic<std::chrono::time_point> m_lastAccessTime;
> std::atomic<std::chrono::time_point> m_lastModifiedTime;
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
