[
https://issues.apache.org/jira/browse/GEODE-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280691#comment-16280691
]
ASF GitHub Bot commented on GEODE-2668:
---------------------------------------
PurelyApplied commented on a change in pull request #1127: GEODE-2668: build
tabular command result from a list of function results
URL: https://github.com/apache/geode/pull/1127#discussion_r155322158
##########
File path:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateGatewaySenderCommand.java
##########
@@ -60,8 +62,9 @@ public Result createGatewaySender(@CliOption(key =
{CliStrings.GROUP, CliStrings
@CliOption(key =
CliStrings.CREATE_GATEWAYSENDER__REMOTEDISTRIBUTEDSYSTEMID, mandatory = true,
help =
CliStrings.CREATE_GATEWAYSENDER__REMOTEDISTRIBUTEDSYSTEMID__HELP) Integer
remoteDistributedSystemId,
Review comment:
While I personally like the readability of the extra spacing in a long list
of `CliOption` arguments, it's counter to all our other `GfshCommand` classes.
Would it be preferable to expand other commands or to collapse this one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add gfsh command to destroy gateway receiver
> --------------------------------------------
>
> Key: GEODE-2668
> URL: https://issues.apache.org/jira/browse/GEODE-2668
> Project: Geode
> Issue Type: Sub-task
> Components: docs, gfsh
> Reporter: Swapnil Bawaskar
>
> Currently, there is a {{create gateway-receiver}} command, but no
> corresponding destroy command.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
