[
https://issues.apache.org/jira/browse/GEODE-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280686#comment-16280686
]
ASF GitHub Bot commented on GEODE-2668:
---------------------------------------
PurelyApplied commented on a change in pull request #1127: GEODE-2668: build
tabular command result from a list of function results
URL: https://github.com/apache/geode/pull/1127#discussion_r155322641
##########
File path:
geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateGatewaySenderCommand.java
##########
@@ -96,64 +99,63 @@ public Result createGatewaySender(@CliOption(key =
{CliStrings.GROUP, CliStrings
@CliOption(key = CliStrings.CREATE_GATEWAYSENDER__ALERTTHRESHOLD,
help = CliStrings.CREATE_GATEWAYSENDER__ALERTTHRESHOLD__HELP)
Integer alertThreshold,
- @CliOption(key = CliStrings.CREATE_GATEWAYSENDER__DISPATCHERTHREADS,
+ @CliOption(key = CREATE_GATEWAYSENDER__DISPATCHERTHREADS,
help = CliStrings.CREATE_GATEWAYSENDER__DISPATCHERTHREADS__HELP)
Integer dispatcherThreads,
- @CliOption(key = CliStrings.CREATE_GATEWAYSENDER__ORDERPOLICY,
- help = CliStrings.CREATE_GATEWAYSENDER__ORDERPOLICY__HELP) String
orderPolicy,
+ @CliOption(key = CREATE_GATEWAYSENDER__ORDERPOLICY,
Review comment:
For consistency, either statically import all the used `CliString` fields or
refer to all of them via the class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add gfsh command to destroy gateway receiver
> --------------------------------------------
>
> Key: GEODE-2668
> URL: https://issues.apache.org/jira/browse/GEODE-2668
> Project: Geode
> Issue Type: Sub-task
> Components: docs, gfsh
> Reporter: Swapnil Bawaskar
>
> Currently, there is a {{create gateway-receiver}} command, but no
> corresponding destroy command.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
