[
https://issues.apache.org/jira/browse/GEODE-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280736#comment-16280736
]
ASF GitHub Bot commented on GEODE-2668:
---------------------------------------
pdxrunner commented on a change in pull request #1127: GEODE-2668: build
tabular command result from a list of function results
URL: https://github.com/apache/geode/pull/1127#discussion_r155335054
##########
File path:
geode-core/src/main/java/org/apache/geode/management/internal/cli/result/ResultBuilder.java
##########
@@ -188,6 +189,22 @@ public static CommandResult buildResult(ResultData
resultData) {
return new CommandResult(resultData);
}
+ public static CommandResult buildResult(List<CliFunctionResult>
functionResults) {
+ TabularResultData tabularData = ResultBuilder.createTabularResultData();
+ boolean success = false;
+ for (CliFunctionResult result : functionResults) {
+ tabularData.accumulate("Member", result.getMemberIdOrName());
+ tabularData.accumulate("Status", result.getStatus());
+ // if one member returns back successful results, the command results in
success
+ if (result.isSuccessful()) {
+ success = true;
+ }
+ }
+
+ tabularData.setStatus(success ? Result.Status.OK : Result.Status.ERROR);
+ return ResultBuilder.buildResult(tabularData);
+ }
Review comment:
With regard to destroy region and create region commands. You're assuming
that when destroying, if destroy succeeded on one, say, member1, then it may
fail on member2 because with a distributed destroy the region may already have
been destroyed before the function is executed on member2.
However with create, the region is being created on a set of members, if
creation succeeds on one member but fails on another, did the command really
succeed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add gfsh command to destroy gateway receiver
> --------------------------------------------
>
> Key: GEODE-2668
> URL: https://issues.apache.org/jira/browse/GEODE-2668
> Project: Geode
> Issue Type: Sub-task
> Components: docs, gfsh
> Reporter: Swapnil Bawaskar
>
> Currently, there is a {{create gateway-receiver}} command, but no
> corresponding destroy command.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
