[
https://issues.apache.org/jira/browse/GEODE-8099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17144289#comment-17144289
]
ASF GitHub Bot commented on GEODE-8099:
---------------------------------------
jinmeiliao commented on a change in pull request #5285:
URL: https://github.com/apache/geode/pull/5285#discussion_r445142428
##########
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/remote/OnlineCommandProcessor.java
##########
@@ -53,14 +57,13 @@
private SecurityService securityService;
- private InternalCache cache;
-
public OnlineCommandProcessor() {}
@VisibleForTesting
- public OnlineCommandProcessor(Properties cacheProperties, SecurityService
securityService,
- CommandExecutor commandExecutor, InternalCache cache) {
- this.gfshParser = new GfshParser(new CommandManager(cacheProperties,
cache));
+ public OnlineCommandProcessor(GfshParser gfshParser,
Review comment:
the change is necessary for the test to pass. All this change is because
public methods in DlockService are static.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make ClusterConfiguration Service thread safe
> ---------------------------------------------
>
> Key: GEODE-8099
> URL: https://issues.apache.org/jira/browse/GEODE-8099
> Project: Geode
> Issue Type: Bug
> Components: configuration
> Reporter: Anilkumar Gingade
> Priority: Major
> Labels: GeodeOperationAPI
> Fix For: 1.14.0
>
>
> When multiple cluster configuration clients (multiple rest clients) connects
> and issue configuration commands, the cluster configuration should handle
> concurrent request and modify/save/execute the configuration definition in
> thread safe manner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
