[
https://issues.apache.org/jira/browse/GEODE-8099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17146745#comment-17146745
]
ASF GitHub Bot commented on GEODE-8099:
---------------------------------------
jinmeiliao commented on a change in pull request #5285:
URL: https://github.com/apache/geode/pull/5285#discussion_r446474804
##########
File path:
geode-core/src/main/java/org/apache/geode/management/internal/api/LocatorClusterManagementService.java
##########
@@ -113,7 +113,7 @@
public class LocatorClusterManagementService implements
ClusterManagementService {
@VisibleForTesting
// the dlock service name used by the CMS
- static final String CMS_DLOCK_SERVICE_NAME = "CMS_DLOCK_SERVICE";
+ public static final String CMS_DLOCK_SERVICE_NAME = "CMS_DLOCK_SERVICE";
Review comment:
Yes, the `InternalConfigurationPersistenceService` is used by both rest
and gfsh to persist the configuration change in the region, and it already has
its own dlockService to make sure update to the region is thread safe.
What are trying to. make thread-safe in here is not just "update to the
region", it's the "update to the server sand then update the region", which is
a level above the persistence layer. Both rest and gfsh does this and so both
needs the same dlockService.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Make ClusterConfiguration Service thread safe
> ---------------------------------------------
>
> Key: GEODE-8099
> URL: https://issues.apache.org/jira/browse/GEODE-8099
> Project: Geode
> Issue Type: Bug
> Components: configuration
> Reporter: Anilkumar Gingade
> Priority: Major
> Labels: GeodeOperationAPI
> Fix For: 1.14.0
>
>
> When multiple cluster configuration clients (multiple rest clients) connects
> and issue configuration commands, the cluster configuration should handle
> concurrent request and modify/save/execute the configuration definition in
> thread safe manner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
