[
https://issues.apache.org/jira/browse/GEODE-8851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268716#comment-17268716
]
ASF GitHub Bot commented on GEODE-8851:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #5928:
URL: https://github.com/apache/geode/pull/5928#discussion_r561134220
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionRemoteContext.java
##########
@@ -86,7 +86,12 @@ public void fromData(DataInput in) throws IOException,
ClassNotFoundException {
}
this.isReExecute = DataSerializer.readBoolean(in);
- if
(StaticSerialization.getVersionForDataStream(in).isNotOlderThan(KnownVersion.GEODE_1_14_0))
{
+ KnownVersion dataStreamVersion =
StaticSerialization.getVersionForDataStream(in);
+ if (dataStreamVersion.isNewerThanOrEqualTo(KnownVersion.GEODE_1_14_0)
Review comment:
Do you think it would be more readable to define a new method like.
```
dataStreamVersion.isBetween(KnownVersion.GEODE_1_12_1,
KnownVersion.GEODE_1_13_0)
```
My concern with such a method is questioning which terms are inclusive or
exclusive. The above is `[KnownVersion.GEODE_1_12_1,
KnownVersion.GEODE_1_13_0)`. Given that the eldest in the 1.12.x isn't know we
can't define a consistently inclusive range either. We can define a
consistently exclusive range, `(KnownVersion.GEODE_1_12_0,
KnownVersion.GEODE_1_13_0)`.
```
dataStreamVersion.isBetweenExclusive(KnownVersion.GEODE_1_12_0,
KnownVersion.GEODE_1_13_0)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> FunctionRemoteContext should support version ordinals GEODE_1_12_1 and
> GEODE_1_13_1
> -----------------------------------------------------------------------------------
>
> Key: GEODE-8851
> URL: https://issues.apache.org/jira/browse/GEODE-8851
> Project: Geode
> Issue Type: Improvement
> Components: core
> Reporter: Jens Deppe
> Priority: Major
> Labels: pull-request-available
>
> Pre-empt the actual releases containing these ordinals.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
