[
https://issues.apache.org/jira/browse/GEODE-8851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268800#comment-17268800
]
ASF GitHub Bot commented on GEODE-8851:
---------------------------------------
jdeppe-pivotal commented on a change in pull request #5928:
URL: https://github.com/apache/geode/pull/5928#discussion_r561207901
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/execute/FunctionRemoteContext.java
##########
@@ -86,7 +86,12 @@ public void fromData(DataInput in) throws IOException,
ClassNotFoundException {
}
this.isReExecute = DataSerializer.readBoolean(in);
- if
(StaticSerialization.getVersionForDataStream(in).isNotOlderThan(KnownVersion.GEODE_1_14_0))
{
+ KnownVersion dataStreamVersion =
StaticSerialization.getVersionForDataStream(in);
+ if (dataStreamVersion.isNewerThanOrEqualTo(KnownVersion.GEODE_1_14_0)
Review comment:
Yeah - if it starts happening in more places we can add something more
saner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> FunctionRemoteContext should support version ordinals GEODE_1_12_1 and
> GEODE_1_13_1
> -----------------------------------------------------------------------------------
>
> Key: GEODE-8851
> URL: https://issues.apache.org/jira/browse/GEODE-8851
> Project: Geode
> Issue Type: Improvement
> Components: core
> Reporter: Jens Deppe
> Priority: Major
> Labels: pull-request-available
>
> Pre-empt the actual releases containing these ordinals.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
