[
https://issues.apache.org/jira/browse/GEODE-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17269878#comment-17269878
]
ASF GitHub Bot commented on GEODE-8855:
---------------------------------------
jdeppe-pivotal commented on a change in pull request #5937:
URL: https://github.com/apache/geode/pull/5937#discussion_r561977373
##########
File path:
geode-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/server/AbstractHitsMissesIntegrationTest.java
##########
@@ -244,28 +392,24 @@ public void testSunionstore() {
runDiffStoreCommandAndAssertNoStatUpdates("set", (k, v, s) ->
jedis.sunionstore(k, v, s));
}
- // ------------ Hash related commands -----------
-
+ // TODO our implementation updates the stats when it shouldn't
+ @Ignore
Review comment:
I've opened GEODE-8857 to fix SMOVE. Please add this Jira to the
`@Ignore` here.
##########
File path:
geode-redis/src/acceptanceTest/java/org/apache/geode/redis/internal/executor/server/InfoNativeRedisAcceptanceTest.java
##########
@@ -28,9 +28,4 @@
public int getPort() {
return redis.getPort();
}
-
- @Override
- int getExposedPort() {
Review comment:
You will probably need to revert this. When run under docker, there are
2 ports in play - one is the external port exposed for outside access and one
is the internal port which the external port is proxied to. It's the internal
port that this is returning and that's the port that the Info command will
report.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Redis Integration Test: add tests for all commands to
> redisStatsIntegrationTest
> -------------------------------------------------------------------------------
>
> Key: GEODE-8855
> URL: https://issues.apache.org/jira/browse/GEODE-8855
> Project: Geode
> Issue Type: Test
> Components: redis
> Reporter: Helena Bales
> Priority: Major
> Labels: pull-request-available
>
> add tests for the unsupported commands and the rest of the untested commands.
> organize the tests. make the tests run against redis and native redis. remove
> duplicate tests from the hitsmisses test.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
