[
https://issues.apache.org/jira/browse/GEODE-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17270381#comment-17270381
]
ASF GitHub Bot commented on GEODE-8855:
---------------------------------------
nonbinaryprogrammer commented on a change in pull request #5937:
URL: https://github.com/apache/geode/pull/5937#discussion_r562864838
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/data/RedisHashCommandsFunctionExecutor.java
##########
@@ -102,14 +102,14 @@ public int hstrlen(ByteArrayWrapper key, ByteArrayWrapper
field) {
@Override
public long hincrby(ByteArrayWrapper key, ByteArrayWrapper field, long
increment) {
return stripedExecute(key,
- () -> getRedisHash(key, true)
+ () -> getRedisHash(key, false)
Review comment:
👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Redis Integration Test: add tests for all commands to
> redisStatsIntegrationTest
> -------------------------------------------------------------------------------
>
> Key: GEODE-8855
> URL: https://issues.apache.org/jira/browse/GEODE-8855
> Project: Geode
> Issue Type: Test
> Components: redis
> Reporter: Helena Bales
> Priority: Major
> Labels: pull-request-available
>
> add tests for the unsupported commands and the rest of the untested commands.
> organize the tests. make the tests run against redis and native redis. remove
> duplicate tests from the hitsmisses test.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
