[
https://issues.apache.org/jira/browse/GEODE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17290542#comment-17290542
]
ASF GitHub Bot commented on GEODE-8962:
---------------------------------------
agingade commented on a change in pull request #6044:
URL: https://github.com/apache/geode/pull/6044#discussion_r582372036
##########
File path:
geode-core/src/main/java/org/apache/geode/cache/query/internal/CompiledLike.java
##########
@@ -349,6 +349,30 @@ private String getRegexPattern(String pattern) {
sb.append(ch);
}
break;
+ case '$': // replace with [$]
+ if (prevMetaChar) {
+ sb.append('\\');
+ sb.append('E');
+ prevMetaChar = false;
+ }
+
+ numConsecutiveBackSlash = 0;
+ for (int j = i - 1; j > -1; --j) {
+ if (pattern.charAt(j) == '\\') {
+ ++numConsecutiveBackSlash;
+ } else {
+ break;
+ }
+ }
+
+ // Check if the $ has a valid escape. Backtrack to check for \.
Review comment:
Why "$" needs to be escaped being a literal in like predicate value. The
special characters that are used in LIKE or "_", "%" and "\" these chars needs
to be escaped with escape char "\".
I think we should be able to compare the "$" literal within the like
predicate without escaping it. Please let me know if I am missing anything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Not possible to escape "$" character in query using LIKE operator
> -----------------------------------------------------------------
>
> Key: GEODE-8962
> URL: https://issues.apache.org/jira/browse/GEODE-8962
> Project: Geode
> Issue Type: Bug
> Components: querying
> Reporter: Mario Kevo
> Assignee: Mario Kevo
> Priority: Major
> Labels: pull-request-available
>
> {color:#000000}If one query tries to match a string containg "$" character by
> a "=" or a "contains" operation, it works, and if data contains a "$"
> character and expression of query looks for it, works as expected.{color}
> {color:#172b4d} {color}
>
> {code:java}
> gfsh>query --query="select e.key from /example-region.entrySet e where
> e.key='aa$b'"
> Result : true
> Limit : 100
> Rows : 1
> Result
> ------
> aa$b{code}
>
>
> {color:#000000}But if we replace the "=" operator in the Geode query by a
> "LIKE" operator, and a wildcard is added, then it seems the regular
> expression mode is somehow triggered and the "$" character starts behaving
> like endline character. That is expected. {color}{color:#172b4d}
> {color}
> {color:#172b4d} {color}
>
> {code:java}
> gfsh>query --query="select e.key from /example-region.entrySet e where e.key
> like 'aa$b'"
> Result : true
> Limit : 100
> Rows : 0
> {code}
>
>
> {color:#000000}There is no way to escape "$" character.{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
