[ 
https://issues.apache.org/jira/browse/GEODE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17291895#comment-17291895
 ] 

ASF GitHub Bot commented on GEODE-8962:
---------------------------------------

kirklund commented on a change in pull request #6044:
URL: https://github.com/apache/geode/pull/6044#discussion_r583876477



##########
File path: 
geode-dunit/src/main/java/org/apache/geode/management/internal/cli/commands/QueryCommandDUnitTestBase.java
##########
@@ -200,6 +212,14 @@ private static void prepareDataForRegion(String 
regionPath) {
     }
   }
 
+  private static void prepareDataForRegionWithSpecialCharacters(String 
regionPath) {
+    InternalCache cache = ClusterStartupRule.getCache();
+    Region dataRegion = cache.getRegion(regionPath);

Review comment:
       Don't worry about the other lines in this old class that use raw types.

##########
File path: 
geode-dunit/src/main/java/org/apache/geode/management/internal/cli/commands/QueryCommandDUnitTestBase.java
##########
@@ -200,6 +212,14 @@ private static void prepareDataForRegion(String 
regionPath) {
     }
   }
 
+  private static void prepareDataForRegionWithSpecialCharacters(String 
regionPath) {
+    InternalCache cache = ClusterStartupRule.getCache();
+    Region dataRegion = cache.getRegion(regionPath);

Review comment:
       Please try to use non-raw types in places like this. There's an IntelliJ 
inspection you can enable that'll highlight lines like this:
   ```
   Region<Integer, String> dataRegion = cache.getRegion(regionPath);
   
   dataRegion.put(1, "value$");
   dataRegion.put(2, "value%");
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Not possible to escape "$" character in query using LIKE operator
> -----------------------------------------------------------------
>
>                 Key: GEODE-8962
>                 URL: https://issues.apache.org/jira/browse/GEODE-8962
>             Project: Geode
>          Issue Type: Bug
>          Components: querying
>            Reporter: Mario Kevo
>            Assignee: Mario Kevo
>            Priority: Major
>              Labels: pull-request-available
>
> {color:#000000}If one query tries to match a string containg "$" character by 
> a "=" or a "contains" operation, it works, and if data contains a "$" 
> character and expression of query looks for it, works as expected.{color}
> {color:#172b4d} {color}
>  
> {code:java}
> gfsh>query --query="select e.key from /example-region.entrySet e where 
> e.key='aa$b'"
> Result : true 
> Limit  : 100 
> Rows   : 1   
> Result
> ------ 
> aa$b{code}
>  
>  
> {color:#000000}But if we replace the "=" operator in the Geode query by a 
> "LIKE" operator, and a wildcard is added, then it seems the regular 
> expression mode is somehow triggered and the "$" character starts behaving 
> like endline character. That is expected. {color}{color:#172b4d}
> {color}
> {color:#172b4d} {color}
>  
> {code:java}
> gfsh>query --query="select e.key from /example-region.entrySet e where e.key 
> like 'aa$b'"
> Result : true 
> Limit  : 100 
> Rows   : 0
> {code}
>  
>  
> {color:#000000}There is no way to escape "$" character.{color}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to