[
https://issues.apache.org/jira/browse/GEODE-9078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17337456#comment-17337456
]
ASF GitHub Bot commented on GEODE-9078:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #776:
URL: https://github.com/apache/geode-native/pull/776#discussion_r623969622
##########
File path: cppcache/src/AdminRegion.hpp
##########
@@ -48,7 +48,7 @@ class AdminRegion : public
std::enable_shared_from_this<AdminRegion> {
ThinClientBaseDM* m_distMngr;
std::string m_fullPath;
TcrConnectionManager* m_connectionMgr;
- ACE_RW_Thread_Mutex m_rwLock;
+ boost::shared_mutex mutex_;
Review comment:
I have the exact same problem. If the changes are small I just do them.
If they are big-sh then I do them on a separate commit so the reviewers can
focus on real change first and then the reformats/refactors separately. If the
changes are really big I keep the same style and then open a new ticket to do a
mass cleanup of the file(s). It's a judgement call.
For this one I would probably just keep the old style for consistency, which
really hurts me but less than having a mix of styles.
Your call though really...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove ACE mutexes
> ------------------
>
> Key: GEODE-9078
> URL: https://issues.apache.org/jira/browse/GEODE-9078
> Project: Geode
> Issue Type: Task
> Components: native client
> Reporter: Mario Salazar de Torres
> Assignee: Mario Salazar de Torres
> Priority: Major
> Labels: obliterate-ace, pull-request-available
>
> *AS AN* geode-native contributor
> *I WANT TO* remove all occurrences of ACE mutexes
> *SO THAT* we can get rid of ACE for good
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
