[
https://issues.apache.org/jira/browse/GEODE-9078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17337655#comment-17337655
]
ASF GitHub Bot commented on GEODE-9078:
---------------------------------------
gaussianrecurrence commented on pull request #776:
URL: https://github.com/apache/geode-native/pull/776#issuecomment-830430021
I
> @gaussianrecurrence Big sorry! I think I have lead you down a habit hole.
It looks like we never called out our deviations from the Google C++ Style
Guide. I for one actually don't mind the `_` separator model in C++ but we had
been preserving the `camelCase` model. We just adopted the trailing `_` for
member variables. We have a few other deviations would should probably have
documented too.
>
> https://github.com/apache/geode-native/blob/develop/CONTRIBUTING.md#style
>
> Even our examples avoid this because they are all single words.
>
> Let's see what other members of the team think on moving on fully to the
Google `_` style?
>
> @pdxcodemonkey @mmartell @mreddington @echobravopapa @mivanac
I guess you mention it because of the make_lock methods right? I did follow
another existing example to name the member function. However if you prefer to
stick to the agreed camelCase notation, I can change it, no problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove ACE mutexes
> ------------------
>
> Key: GEODE-9078
> URL: https://issues.apache.org/jira/browse/GEODE-9078
> Project: Geode
> Issue Type: Task
> Components: native client
> Reporter: Mario Salazar de Torres
> Assignee: Mario Salazar de Torres
> Priority: Major
> Labels: obliterate-ace, pull-request-available
>
> *AS AN* geode-native contributor
> *I WANT TO* remove all occurrences of ACE mutexes
> *SO THAT* we can get rid of ACE for good
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
