[
https://issues.apache.org/jira/browse/GEODE-8679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17343313#comment-17343313
]
ASF GitHub Bot commented on GEODE-8679:
---------------------------------------
pdxcodemonkey commented on a change in pull request #761:
URL: https://github.com/apache/geode-native/pull/761#discussion_r631151376
##########
File path: cppcache/integration-test/LibraryCallbacks.cpp
##########
@@ -29,7 +29,7 @@ void dummyFunc() {}
} // namespace test
#define SLEEP(x) std::this_thread::sleep_for(std::chrono::milliseconds(x))
-#define LOG LOGDEBUG
+#define LOG LOG_DEBUG
Review comment:
Agree 100% in principle, but I think this is beyond the scope of the
current PR. To give you an idea of the size of this task, here is the result
of "find in files" for `LOG`, whole-word only, so I'd only catch test code that
was using some variation of this hokey define:
`Matching lines: 2609 Matching files: 112 Total files searched: 1167`
That's a whooooole lot of logging to go remove from code that is targeted
for deprecation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Replace Native logger with 3rd party solution
> ---------------------------------------------
>
> Key: GEODE-8679
> URL: https://issues.apache.org/jira/browse/GEODE-8679
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Blake Bender
> Priority: Major
> Labels: pull-request-available
>
> As a native client developer, I would prefer to only maintain code that
> actually implements core features of a Geode client. A logging subsystem is
> definitely not core Geode functionality. Additionally, the existing
> geode-native logger does not properly support the `loig-file-size-limit` and
> `log-disk-space-limit` properties. Rather than attempt to fix the existing
> logging code to properly implement these, we should switch to a 3rd-party
> solution (spdlog or similar) that already has these features available and
> working.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
