[
https://issues.apache.org/jira/browse/GEODE-8679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17343935#comment-17343935
]
ASF GitHub Bot commented on GEODE-8679:
---------------------------------------
pdxcodemonkey commented on a change in pull request #761:
URL: https://github.com/apache/geode-native/pull/761#discussion_r631892232
##########
File path: dependencies/spdlog/CMakeLists.txt
##########
@@ -0,0 +1,51 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+project( spdlog VERSION 1.3.1 LANGUAGES NONE )
+
+set( SHA256 db6986d0141546d4fba5220944cc1f251bd8afdfc434bda173b4b0b6406e3cd0 )
+
+include(GNUInstallDirs)
+include(ExternalProject)
+
+ExternalProject_Add( ${PROJECT_NAME}-extern
+ URL "https://github.com/gabime/spdlog/archive/v${PROJECT_VERSION}.zip";
Review comment:
Dunno, but for sure we're already way out of date. Current version is
1.8.5, will update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Replace Native logger with 3rd party solution
> ---------------------------------------------
>
> Key: GEODE-8679
> URL: https://issues.apache.org/jira/browse/GEODE-8679
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Blake Bender
> Priority: Major
> Labels: pull-request-available
>
> As a native client developer, I would prefer to only maintain code that
> actually implements core features of a Geode client. A logging subsystem is
> definitely not core Geode functionality. Additionally, the existing
> geode-native logger does not properly support the `loig-file-size-limit` and
> `log-disk-space-limit` properties. Rather than attempt to fix the existing
> logging code to properly implement these, we should switch to a 3rd-party
> solution (spdlog or similar) that already has these features available and
> working.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
