[
https://issues.apache.org/jira/browse/GEODE-9078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17343359#comment-17343359
]
ASF GitHub Bot commented on GEODE-9078:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #776:
URL: https://github.com/apache/geode-native/pull/776#discussion_r631220291
##########
File path: cppcache/src/RemoteQuery.cpp
##########
@@ -125,11 +127,11 @@ GfErrType RemoteQuery::executeNoThrow(
ThinClientBaseDM* tcdm, std::shared_ptr<CacheableVector> paramList) {
LOGFINEST("%s: executing query: %s", func, m_queryString.c_str());
- TryReadGuard guard(m_queryService->getLock(), m_queryService->invalid());
-
+ boost::shared_lock<boost::shared_mutex> guard{m_queryService->getMutex()};
Review comment:
Were you going to change these patterns to return a `shared_lock` rather
than the `shared_mutex`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Remove ACE mutexes
> ------------------
>
> Key: GEODE-9078
> URL: https://issues.apache.org/jira/browse/GEODE-9078
> Project: Geode
> Issue Type: Task
> Components: native client
> Reporter: Mario Salazar de Torres
> Assignee: Mario Salazar de Torres
> Priority: Major
> Labels: obliterate-ace, pull-request-available
>
> *AS AN* geode-native contributor
> *I WANT TO* remove all occurrences of ACE mutexes
> *SO THAT* we can get rid of ACE for good
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
