[ https://issues.apache.org/jira/browse/GEODE-10300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17564825#comment-17564825 ]
ASF GitHub Bot commented on GEODE-10300: ---------------------------------------- albertogpz commented on code in PR #970: URL: https://github.com/apache/geode-native/pull/970#discussion_r917628356 ########## cppcache/include/geode/DataInput.hpp: ########## @@ -502,21 +502,21 @@ class APACHE_GEODE_EXPORT DataInput { inline char readPdxChar() { return static_cast<char>(readInt16()); } - inline void _checkBufferSize(size_t size, int32_t line) { - if ((m_bufLength - (m_buf - m_bufHead)) < size) { + virtual void _checkBufferSize(size_t size, int32_t line) { Review Comment: I am afraid it is necessary for the solution. But given that this will go in a minor release I do not think it is an issue. Is there a log file in place where I could add this change as proposed in: https://lists.apache.org/thread/0v2r5trv926oj8qrgfp00467y3rycsvw > C++ Native client messages coming from the locator cannot be longer than 3000 > bytes > ----------------------------------------------------------------------------------- > > Key: GEODE-10300 > URL: https://issues.apache.org/jira/browse/GEODE-10300 > Project: Geode > Issue Type: Bug > Components: native client > Reporter: Alberto Gomez > Assignee: Alberto Gomez > Priority: Major > Labels: pull-request-available > > If a locator sends a response to the C++ native client that is longer than > 3000 bytes the C++ native client library will only read the first 3000 bytes. -- This message was sent by Atlassian Jira (v8.20.10#820010)