[ https://issues.apache.org/jira/browse/GEODE-10300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580847#comment-17580847 ]
ASF GitHub Bot commented on GEODE-10300: ---------------------------------------- pivotal-jbarrett commented on code in PR #970: URL: https://github.com/apache/geode-native/pull/970#discussion_r948127352 ########## cppcache/src/StreamDataInput.cpp: ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include "StreamDataInput.hpp" + +#include <geode/DataInput.hpp> + +#include "Utils.hpp" +#include "util/Log.hpp" + +namespace apache { +namespace geode { +namespace client { + +const size_t kBufferSize = 3000; + +StreamDataInput::StreamDataInput(std::chrono::milliseconds timeout, + std::unique_ptr<Connector> connector, + const CacheImpl* cache, Pool* pool) + : DataInput(nullptr, 0, cache, pool), + connector_(std::move(connector)), + remainingTimeBeforeTimeout_(timeout) {} + +void StreamDataInput::readDataIfNotAvailable(size_t size) { + char buff[kBufferSize]; + while (getBytesRemaining() < size) { + const auto start = std::chrono::system_clock::now(); + + const auto receivedLength = connector_->receive_nothrowiftimeout( + buff, kBufferSize, + std::chrono::duration_cast<std::chrono::milliseconds>( + remainingTimeBeforeTimeout_)); Review Comment: The duration cast can go away now that all time is milliseconds. > C++ Native client messages coming from the locator cannot be longer than 3000 > bytes > ----------------------------------------------------------------------------------- > > Key: GEODE-10300 > URL: https://issues.apache.org/jira/browse/GEODE-10300 > Project: Geode > Issue Type: Bug > Components: native client > Reporter: Alberto Gomez > Assignee: Alberto Gomez > Priority: Major > Labels: pull-request-available > > If a locator sends a response to the C++ native client that is longer than > 3000 bytes the C++ native client library will only read the first 3000 bytes. -- This message was sent by Atlassian Jira (v8.20.10#820010)