[
https://issues.apache.org/jira/browse/GEODE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15416106#comment-15416106
]
ASF GitHub Bot commented on GEODE-1744:
---------------------------------------
Github user kjduling commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/230#discussion_r74340020
--- Diff:
geode-core/src/main/java/com/gemstone/gemfire/admin/AlertLevel.java ---
@@ -145,8 +147,8 @@ public boolean equals(Object other) {
final AlertLevel that = (AlertLevel) other;
if (this.severity != that.severity) return false;
- if (this.name != that.name &&
- !(this.name != null &&
+ if (!Objects.equals(this.name, that.name) &&
+ !(this.name != null &&
this.name.equals(that.name))) return false;
--- End diff --
Yep, absolutely correct.
> Probable Bugs from == use
> -------------------------
>
> Key: GEODE-1744
> URL: https://issues.apache.org/jira/browse/GEODE-1744
> Project: Geode
> Issue Type: Bug
> Reporter: Grace Meilen
> Assignee: Grace Meilen
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
