[
https://issues.apache.org/jira/browse/GEODE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15416117#comment-15416117
]
ASF GitHub Bot commented on GEODE-1744:
---------------------------------------
Github user kjduling commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/230#discussion_r74340943
--- Diff:
geode-core/src/main/java/com/gemstone/gemfire/management/internal/cli/AbstractCliAroundInterceptor.java
---
@@ -88,7 +88,7 @@ protected Response readYesNo(String message, Response
defaultResponse) {
try {
String userInput = interact(message);
- if (userInput == null || userInput == "") {
+ if (userInput.isEmpty()) {
--- End diff --
Here you need to keep the null check or it could throw an NPE, so:
if (userInput == null || userInput.isEmpty()) {
> Probable Bugs from == use
> -------------------------
>
> Key: GEODE-1744
> URL: https://issues.apache.org/jira/browse/GEODE-1744
> Project: Geode
> Issue Type: Bug
> Reporter: Grace Meilen
> Assignee: Grace Meilen
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
