Github user stanlyxiang commented on a diff in the pull request:

    https://github.com/apache/hawq/pull/1399#discussion_r231037423
  
    --- Diff: contrib/orc/orc_format/orc_format.c ---
    @@ -0,0 +1 @@
    +//this is a test file for compiling.
    --- End diff --
    
    if this file is useless, please do not add it to the commit.
    if you use it as a placeholder, please add a more formal c source file with 
license header, otherwise your file won't pass apache-rat-check and no one will 
merge your commit to master.


---

Reply via email to