Github user ion2014 commented on a diff in the pull request:

    https://github.com/apache/hawq/pull/1399#discussion_r231042590
  
    --- Diff: contrib/hawq-hadoop/Makefile ---
    @@ -41,9 +41,9 @@ all: $(DEFAULTTARGET)
     $(DEFAULTTARGET):
     ifdef MAVEN
     ifeq ($(shell java -version 2>&1 | grep 1.7.0 > /dev/null; printf $$?),0)
    -   $(MAVEN) package -DskipTests -Dhttps.protocols=TLSv1.2
    +   $(MAVEN) package -DskipTests -Dmaven.javadoc.skip=true  
-Dhttps.protocols=TLSv1.2
    --- End diff --
    
    maybe I'll start a subtask individually for JDK8 support in another commit, 
thanks for your review!


---

Reply via email to