[
https://issues.apache.org/jira/browse/HAWQ-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120832#comment-15120832
]
ASF GitHub Bot commented on HAWQ-253:
-------------------------------------
Github user sansanichfb commented on the pull request:
https://github.com/apache/incubator-hawq/pull/299#issuecomment-175997860
LGTM
> Separate pxf-hdfs and pxf-hive packages from pxf-service
> --------------------------------------------------------
>
> Key: HAWQ-253
> URL: https://issues.apache.org/jira/browse/HAWQ-253
> Project: Apache HAWQ
> Issue Type: Bug
> Components: PXF
> Reporter: Noa Horn
> Assignee: Noa Horn
> Fix For: backlog
>
>
> The PXF plugins should only depend on pxf-api package.
> pxf-service is supposed to be an internal package, not exposed to the plugins.
> Currently both pxf-hdfs and pxf-hive depend on pxf-service, which should be
> fixed.
> {noformat}
> $ grep -rI "pxf.service" pxf-hdfs/src/main/.
> pxf-hdfs/src/main/./java/org/apache/hawq/pxf/plugins/hdfs/HdfsAnalyzer.java:import
> org.apache.hawq.pxf.service.ReadBridge;
> pxf-hdfs/src/main/./java/org/apache/hawq/pxf/plugins/hdfs/utilities/HdfsUtilities.java:import
> org.apache.hawq.pxf.service.utilities.Utilities;
> pxf-hdfs/src/main/./java/org/apache/hawq/pxf/plugins/hdfs/WritableResolver.java:import
> org.apache.hawq.pxf.service.utilities.Utilities;
> $ grep -rI "pxf.service" pxf-hive/src/main/.
> pxf-hive/src/main/./java/org/apache/hawq/pxf/plugins/hive/HiveColumnarSerdeResolver.java:import
> org.apache.hawq.pxf.service.utilities.Utilities;
> pxf-hive/src/main/./java/org/apache/hawq/pxf/plugins/hive/HiveResolver.java:import
> org.apache.hawq.pxf.service.utilities.Utilities;
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
