[
https://issues.apache.org/jira/browse/HAWQ-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15122194#comment-15122194
]
ASF GitHub Bot commented on HAWQ-253:
-------------------------------------
Github user hornn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/299#discussion_r51176782
--- Diff:
pxf/pxf-service/src/test/java/org/apache/hawq/pxf/service/BridgeInputBuilderTest.java
---
@@ -0,0 +1,154 @@
+package org.apache.hawq.pxf.service;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+import static org.mockito.Mockito.mock;
+
+import java.io.ByteArrayInputStream;
+import java.io.DataInputStream;
+import java.util.Arrays;
+import java.util.List;
+
+import org.apache.hawq.pxf.api.OneField;
+import org.apache.hawq.pxf.api.OutputFormat;
+import org.apache.hawq.pxf.api.io.DataType;
+import org.apache.hawq.pxf.service.utilities.ProtocolData;
+import org.junit.Before;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.powermock.api.mockito.PowerMockito;
+import org.powermock.modules.junit4.PowerMockRunner;
+
+@RunWith(PowerMockRunner.class)
+public class BridgeInputBuilderTest {
+ ProtocolData mockProtocolData;
+
+ @Test
+ /*
+ * Test makeInput method: small \n terminated input
+ */
+ public void makeInput() throws Exception {
+
+ byte[] data = new byte[] {
+ (int) 'a',
+ (int) 'b',
+ (int) 'c',
+ (int) 'd',
+ (int) '\n',
+ (int) 'n',
+ (int) 'o',
+ (int) '\n' };
+
+ DataInputStream inputStream = new DataInputStream(
--- End diff --
Good point, I'll fix it.
> Separate pxf-hdfs and pxf-hive packages from pxf-service
> --------------------------------------------------------
>
> Key: HAWQ-253
> URL: https://issues.apache.org/jira/browse/HAWQ-253
> Project: Apache HAWQ
> Issue Type: Bug
> Components: PXF
> Reporter: Noa Horn
> Assignee: Noa Horn
> Fix For: backlog
>
>
> The PXF plugins should only depend on pxf-api package.
> pxf-service is supposed to be an internal package, not exposed to the plugins.
> Currently both pxf-hdfs and pxf-hive depend on pxf-service, which should be
> fixed.
> {noformat}
> $ grep -rI "pxf.service" pxf-hdfs/src/main/.
> pxf-hdfs/src/main/./java/org/apache/hawq/pxf/plugins/hdfs/HdfsAnalyzer.java:import
> org.apache.hawq.pxf.service.ReadBridge;
> pxf-hdfs/src/main/./java/org/apache/hawq/pxf/plugins/hdfs/utilities/HdfsUtilities.java:import
> org.apache.hawq.pxf.service.utilities.Utilities;
> pxf-hdfs/src/main/./java/org/apache/hawq/pxf/plugins/hdfs/WritableResolver.java:import
> org.apache.hawq.pxf.service.utilities.Utilities;
> $ grep -rI "pxf.service" pxf-hive/src/main/.
> pxf-hive/src/main/./java/org/apache/hawq/pxf/plugins/hive/HiveColumnarSerdeResolver.java:import
> org.apache.hawq.pxf.service.utilities.Utilities;
> pxf-hive/src/main/./java/org/apache/hawq/pxf/plugins/hive/HiveResolver.java:import
> org.apache.hawq.pxf.service.utilities.Utilities;
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
