[
https://issues.apache.org/jira/browse/HAWQ-917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374203#comment-15374203
]
ASF GitHub Bot commented on HAWQ-917:
-------------------------------------
Github user xunzhang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/787#discussion_r70556665
--- Diff: src/test/feature/type/ans/int8.ans ---
@@ -175,131 +179,131 @@ SELECT '' AS to_char_4, to_char( (q1 * -1),
'9999999999999999S'), to_char( (q2 *
SELECT '' AS to_char_5, to_char(q2, 'MI9999999999999999') FROM
INT8_TBL ;
to_char_5 | to_char
-----------+-------------------
- | 123
| 456
| 4567890123456789
+ | 123
| 4567890123456789
| -4567890123456789
(5 rows)
SELECT '' AS to_char_6, to_char(q2, 'FMS9999999999999999') FROM
INT8_TBL ;
to_char_6 | to_char
-----------+-------------------
- | +123
| +456
- | -4567890123456789
| +4567890123456789
+ | +123
| +4567890123456789
+ | -4567890123456789
(5 rows)
SELECT '' AS to_char_7, to_char(q2, 'FM9999999999999999THPR') FROM
INT8_TBL ;
to_char_7 | to_char
-----------+--------------------
- | 123RD
- | <4567890123456789>
+ | 456TH
| 4567890123456789TH
+ | 123RD
| 4567890123456789TH
- | 456TH
+ | <4567890123456789>
(5 rows)
SELECT '' AS to_char_8, to_char(q2, 'SG9999999999999999th') FROM
INT8_TBL ;
to_char_8 | to_char
-----------+---------------------
- | + 123rd
- | -4567890123456789
+ | + 456th
| +4567890123456789th
+ | + 123rd
| +4567890123456789th
- | + 456th
+ | -4567890123456789
(5 rows)
SELECT '' AS to_char_9, to_char(q2, '0999999999999999') FROM
INT8_TBL ;
to_char_9 | to_char
-----------+-------------------
- | 0000000000000123
| 0000000000000456
| 4567890123456789
+ | 0000000000000123
| 4567890123456789
| -4567890123456789
(5 rows)
SELECT '' AS to_char_10, to_char(q2, 'S0999999999999999') FROM
INT8_TBL ;
to_char_10 | to_char
------------+-------------------
- | +0000000000000123
| +0000000000000456
- | -4567890123456789
| +4567890123456789
+ | +0000000000000123
| +4567890123456789
+ | -4567890123456789
(5 rows)
SELECT '' AS to_char_11, to_char(q2, 'FM0999999999999999') FROM
INT8_TBL ;
to_char_11 | to_char
------------+-------------------
- | 0000000000000123
| 0000000000000456
| 4567890123456789
+ | 0000000000000123
| 4567890123456789
| -4567890123456789
(5 rows)
SELECT '' AS to_char_12, to_char(q2, 'FM9999999999999999.000') FROM
INT8_TBL ;
to_char_12 | to_char
------------+-----------------------
- | 123.000
| 456.000
- | -4567890123456789.000
| 4567890123456789.000
+ | 123.000
| 4567890123456789.000
+ | -4567890123456789.000
(5 rows)
SELECT '' AS to_char_13, to_char(q2, 'L9999999999999999.000') FROM
INT8_TBL ;
to_char_13 | to_char
------------+------------------------
- | 123.000
- | 456.000
- | 4567890123456789.000
- | 4567890123456789.000
- | -4567890123456789.000
+ | $ 456.000
+ | $ 4567890123456789.000
+ | $ 123.000
+ | $ 4567890123456789.000
+ | $-4567890123456789.000
--- End diff --
Why did you add `$` sign here?
> Refactor feature tests for data type check with new googletest framework
> ------------------------------------------------------------------------
>
> Key: HAWQ-917
> URL: https://issues.apache.org/jira/browse/HAWQ-917
> Project: Apache HAWQ
> Issue Type: Sub-task
> Reporter: Paul Guo
> Assignee: Paul Guo
>
> This needs to refactor the following 15 test cases.
> ../../../regress/sql/boolean.sql
> ../../../regress/sql/char.sql
> ../../../regress/sql/date.sql
> ../../../regress/sql/float4.sql
> ../../../regress/sql/float8.sql
> ../../../regress/sql/int2.sql
> ../../../regress/sql/int4.sql
> ../../../regress/sql/int8.sql
> ../../../regress/sql/money.sql
> ../../../regress/sql/name.sql
> ../../../regress/sql/oid.sql
> ../../../regress/sql/text.sql
> ../../../regress/sql/time.sql
> ../../../regress/sql/type_sanity.sql
> ../../../regress/sql/varchar.sql
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
