[
https://issues.apache.org/jira/browse/HAWQ-917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374211#comment-15374211
]
ASF GitHub Bot commented on HAWQ-917:
-------------------------------------
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/787#discussion_r70556890
--- Diff: src/test/feature/type/TestType.cpp ---
@@ -0,0 +1,77 @@
+#include "gtest/gtest.h"
+
+#include "lib/sql_util.h"
+
+using std::string;
--- End diff --
It could compile without this. sql_util.h has included <string>. Do we
really need to include this?
> Refactor feature tests for data type check with new googletest framework
> ------------------------------------------------------------------------
>
> Key: HAWQ-917
> URL: https://issues.apache.org/jira/browse/HAWQ-917
> Project: Apache HAWQ
> Issue Type: Sub-task
> Reporter: Paul Guo
> Assignee: Paul Guo
>
> This needs to refactor the following 15 test cases.
> ../../../regress/sql/boolean.sql
> ../../../regress/sql/char.sql
> ../../../regress/sql/date.sql
> ../../../regress/sql/float4.sql
> ../../../regress/sql/float8.sql
> ../../../regress/sql/int2.sql
> ../../../regress/sql/int4.sql
> ../../../regress/sql/int8.sql
> ../../../regress/sql/money.sql
> ../../../regress/sql/name.sql
> ../../../regress/sql/oid.sql
> ../../../regress/sql/text.sql
> ../../../regress/sql/time.sql
> ../../../regress/sql/type_sanity.sql
> ../../../regress/sql/varchar.sql
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
