Github user sansanichfb commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/968#discussion_r84389764
--- Diff: src/backend/access/external/test/pxffilters_test.c ---
@@ -323,10 +323,32 @@ OpExpr* build_op_expr(void* left, void* right, int op)
return expr;
}
-ExpressionItem* build_expression_item(int lattnum, Oid lattrtype, char*
rconststr, Oid rattrtype, int op) {
+NullTest* build_null_expr(void* arg, NullTestType nullType)
--- End diff --
Should we have Expr *arg instead of void* arg?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
