Github user sansanichfb commented on a diff in the pull request: https://github.com/apache/incubator-hawq/pull/968#discussion_r84521841 --- Diff: src/backend/access/external/pxffilters.c --- @@ -406,6 +406,29 @@ pxf_serialize_filter_list(List *expressionItems) appendStringInfo(resbuf, "%c%d", PXF_LOGICAL_OPERATOR_CODE, boolType); break; } + case T_NullTest: + { + elog(DEBUG1, "pxf_serialize_filter_list: node tag %d (T_NullTest)", tag); + NullTest *expr = (NullTest *) node; + + /* filter expression for T_NullTest will not have any constant value */ + if (expr->nulltesttype == IS_NULL) + { + appendStringInfo(resbuf, "%c%d%c%d", PXF_ATTR_CODE, ((Var *) expr->arg)->varattno - 1, PXF_OPERATOR_CODE, PXFOP_IS_NULL); + } + else if (expr->nulltesttype == IS_NOT_NULL) + { + appendStringInfo(resbuf, "%c%d%c%d", PXF_ATTR_CODE, ((Var *) expr->arg)->varattno - 1, PXF_OPERATOR_CODE, PXFOP_IS_NOTNULL); + } + else + { + ereport(ERROR, + (errcode(ERRCODE_INTERNAL_ERROR), + errmsg("internal error in pxffilters.c:pxf_serialize_" + "filter_list. Found a NullTest filter with incorrect opcode"))); --- End diff -- Incorrect NullTestType instead of opcode?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---