Github user xunzhang commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/955#discussion_r85151464
--- Diff: tools/bin/hawqregister ---
@@ -855,6 +888,79 @@ class HawqRegister(object):
logger.info('Hawq Register Succeed.')
+class HawqRegisterPartition(HawqRegister):
--- End diff --
Also, where is the register function of this class? Can we make the
interface consistent? For example,
```
def __init__(self, options, table, utility_conn, conn, failure_handler):
HawqRegister.__init__(self, options, table, utility_conn, conn,
failure_handler)
def register(self):
HawqRegister.register(self)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
