Github user xunzhang commented on the issue:

    https://github.com/apache/incubator-hawq/pull/955
  
    BTW, since current implementation separate files into `self.files_update`, 
`self.files_same_path `, `self.files_append`, it is very tricky and hard to 
read/maintain. I suggest to add some unit test for some key functions for 
readability. 
    
    Still I do not think delete all files and insert into ao_seg.# is a good 
way, it brings complexity for some edge case. If we use this implementation, we 
should add unit tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to