Github user jiadexin commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/972#discussion_r85677094
--- Diff:
pxf/pxf-jdbc/src/test/java/org/apache/hawq/pxf/plugins/jdbc/JdbcFilterBuilderTest.java
---
@@ -0,0 +1,81 @@
+package org.apache.hawq.pxf.plugins.jdbc;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+
+import org.apache.hawq.pxf.api.BasicFilter;
+import org.apache.hawq.pxf.api.FilterParser.LogicalOperation;
+import org.apache.hawq.pxf.api.LogicalFilter;
+import org.junit.Test;
+
+import static org.apache.hawq.pxf.api.FilterParser.Operation.*;
+import static org.junit.Assert.assertEquals;
+
+public class JdbcFilterBuilderTest {
+ @Test
+ public void parseFilterWithThreeOperations() throws Exception {
+ //orgin sql => cdate>'2008-02-01' and cdate<'2008-12-01' and amt >
1200
+ //filterstr="a1c\"first\"o5a2c2o2l0";//col_1=first and col_2=2
+ String filterstr =
"a1c\"2008-02-01\"o2a1c\"2008-12-01\"o1l0a2c1200o2l1"; //col_1>'first' and
col_1<'2008-12-01' or col_2 > 1200;
+ JdbcFilterBuilder builder = new JdbcFilterBuilder();
+
+ LogicalFilter filterList = (LogicalFilter)
builder.getFilterObject(filterstr);
+ assertEquals(LogicalOperation.HDOP_OR, filterList.getOperator());
+ LogicalFilter l1_left = (LogicalFilter)
filterList.getFilterList().get(0);
+ BasicFilter l1_right = (BasicFilter)
filterList.getFilterList().get(1);
+ //column_2 > 1200
+ assertEquals(2, l1_right.getColumn().index());
+ assertEquals(HDOP_GT, l1_right.getOperation());
+ assertEquals(1200L, l1_right.getConstant().constant());
+
+ assertEquals(LogicalOperation.HDOP_AND, l1_left.getOperator());
+ BasicFilter l2_left = (BasicFilter) l1_left.getFilterList().get(0);
+ BasicFilter l2_right = (BasicFilter)
l1_left.getFilterList().get(1);
+
+ //column_1 > '2008-02-01'
+ assertEquals(1, l2_left.getColumn().index());
+ assertEquals(HDOP_GT, l2_left.getOperation());
+ assertEquals("2008-02-01", l2_left.getConstant().constant());
+
+ //column_2 = 5
+ assertEquals(1, l2_right.getColumn().index());
+ assertEquals(HDOP_LT, l2_right.getOperation());
+ assertEquals("2008-12-01", l2_right.getConstant().constant());
+
+ }
+
+ @Test
+ public void parseFilterWithLogicalOperation() throws Exception {
+ WhereSQLBuilder builder = new WhereSQLBuilder(null);
--- End diff --
WhereSQLBuilder used to build sql statement, its 'test' through
JdbcMySqlExtensionTest completed.
There are other ways to test the correctness of sql statement?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
