Github user paul-guo- commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1157#discussion_r103855671
  
    --- Diff: src/backend/executor/nodeShareInputScan.c ---
    @@ -1009,10 +1059,10 @@ shareinput_writer_waitdone(void *ctxt, int 
share_id, int nsharer_xslice)
                {
                        int save_errno = errno;
                        elog(LOG, "SISC WRITER (shareid=%d, slice=%d): wait 
done time out once, errno %d",
    -                                   share_id, currentSliceId, save_errno);
    -                   if(save_errno == EBADF)
    +                                   share_id, currentSliceId, save_errno);  
    +                   if(save_errno == EBADF || save_errno == EINVAL)
                        {
    -                           /* The file description is invalid, maybe this 
FD has been already closed by writer in some cases
    +                           /* The file description is invalid, maybe this 
FD has been already closed by others in some cases
    --- End diff --
    
    The comment does not apply for the check logic.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to