Github user wengyanqing commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1157#discussion_r104548625
--- Diff: src/backend/executor/nodeShareInputScan.c ---
@@ -634,16 +634,16 @@ static int retry_read(int fd, char *buf, int rsize)
read_retry:
sz = read(fd, buf, rsize);
- if (sz > 0)
+ if (sz >= 0)
return sz;
- else if(sz == 0 || errno == EINTR)
+ else if(errno == EINTR)
--- End diff --
It needs to handle EAGAIN in nonblocking read.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
