Github user paul-guo- commented on the issue:

    https://github.com/apache/incubator-hawq/pull/1184
  
    Cool work! I just have one concern.
     
    I saw a lot of fix like this, however is is possible the later one is a 
relative path while DESTDIR has not a tailing / and this could lead to a bug, 
so maybe you could add / between them to prevent this, besides: 1) This will 
make code easier to read 2) even there is // in your path, it is not a problem 
also. How do you think?
    
    $(DESTDIR)${sysconfdir}


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to