Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1384#discussion_r208435034
--- Diff: src/backend/commands/analyze.c ---
@@ -153,9 +160,15 @@ static List *buildExplicitAttributeNames(Oid
relationOid, VacuumStmt *stmt);
static void gp_statistics_estimate_reltuples_relpages_heap(Relation rel,
float4 *reltuples, float4 *relpages);
static void gp_statistics_estimate_reltuples_relpages_ao_rows(Relation
rel, float4 *reltuples, float4 *relpages);
static void gp_statistics_estimate_reltuples_relpages_parquet(Relation
rel, float4 *reltuples, float4 *relpages);
+static void gp_statistics_estimate_reltuples_relpages_external(Relation
rel, float4 *relTuples, float4 *relPages);
static void analyzeEstimateReltuplesRelpages(Oid relationOid, float4
*relTuples, float4 *relPages, bool rootonly);
static void analyzeEstimateIndexpages(Oid relationOid, Oid indexOid,
float4 *indexPages);
+static void getExternalRelTuples(Oid relationOid, float4 *relTuples);
+static void getExternalRelPages(Oid relationOid, float4 *relPages ,
Relation rel);
+static float4 getExtrelPagesHDFS(Uri *uri);
+static bool isExternalHDFSORMAGMAProtocol(Oid relOid);
--- End diff --
Implement only HDFS protocol, not HDFS and Magma
---