[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

[Librago]

Github user Librago commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1384#discussion_r208435735
  
    --- Diff: src/backend/access/external/fileam.c ---
    @@ -782,6 +864,28 @@ external_insert(ExternalInsertDesc extInsertDesc, 
TupleTableSlot *tupTableSlot)
     void
     external_insert_finish(ExternalInsertDesc extInsertDesc)
     {
    +   /* Tell formatter to close */
    +   if (extInsertDesc->ext_formatter_data != NULL &&
    +           (extInsertDesc->ext_formatter_data->fmt_mask & FMT_NEEDEXTBUFF) 
== 0)
    +   {
    +           Datum d;
    +           FunctionCallInfoData fcinfo;
    +
    +           extInsertDesc->ext_formatter_data->fmt_mask |= FMT_WRITE_END;
    +
    +           /* per call formatter prep */
    +           FunctionCallPrepareFormatter(&fcinfo,
    --- End diff --
    
    incorrect indent


---