[GitHub] incubator-hawq pull request #1384: HAWQ-1628. Add HDFS protocol for external...

[Librago]

Github user Librago commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1384#discussion_r208438223
  
    --- Diff: src/backend/commands/analyze.c ---
    @@ -989,17 +1013,20 @@ static List* analyzableRelations(bool rootonly, List 
**fullRelOids)
        while (HeapTupleIsValid(tuple = caql_getnext(pcqCtx)))
        {
                Oid candidateOid = HeapTupleGetOid(tuple);
    -           if (analyzePermitted(candidateOid)
    -                                           && candidateOid != 
StatisticRelationId)
    +           bool isExternalHDFSORMAGMA = 
isExternalHDFSORMAGMAProtocol(candidateOid);
    +           if (analyzePermitted(candidateOid) &&
    +                               candidateOid != StatisticRelationId &&
    +                               isExternalHDFSORMAGMA)
    --- End diff --
    
    remove magma


---